[
https://issues.apache.org/jira/browse/HADOOP-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940323#comment-17940323
]
ASF GitHub Bot commented on HADOOP-19406:
-----------------------------------------
anujmodi2021 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2024449821
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -250,6 +251,7 @@ public void initialize(URI uri, Configuration configuration)
try {
Review Comment:
Need to update the comment above.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelegationSAS.java:
##########
@@ -217,6 +220,7 @@ public void testReadAndWrite() throws Exception {
@Test
public void checkExceptionForRenameOverwrites() throws Exception {
+ assumeHnsEnabled();
Review Comment:
Why??
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsErrors.java:
##########
@@ -62,7 +62,7 @@ public final class AbfsErrors {
/**
* Exception message on filesystem init if token-provider-auth-type configs
are provided
*/
- public static final String UNAUTHORIZED_SAS = "Incorrect SAS token provider
configured for non-hierarchical namespace account.";
+ public static final String UNAUTHORIZED_SAS = "Incorrect SAS token provider
configured for non-hierarchical namespace account with DFS service type.";
Review Comment:
Split line length
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -364,7 +364,7 @@ public AbfsRestOperation listPath(final String
relativePath, final boolean recur
abfsUriQueryBuilder.addQuery(QUERY_PARAM_DELIMITER, FORWARD_SLASH);
}
abfsUriQueryBuilder.addQuery(QUERY_PARAM_MAX_RESULTS,
String.valueOf(listMaxResults));
- appendSASTokenToQuery(relativePath,
SASTokenProvider.FIXED_SAS_STORE_OPERATION, abfsUriQueryBuilder);
+ appendSASTokenToQuery(relativePath, SASTokenProvider.LIST_OPERATION_BLOB,
abfsUriQueryBuilder);
Review Comment:
Why do we need different SASTokenProvider Operation for listing on Blob? Are
permissions different than that of DFS?
##########
hadoop-tools/hadoop-azure/src/site/markdown/abfs.md:
##########
@@ -663,13 +663,13 @@ To know more about how SAS Authentication works refer to
[Grant limited access to Azure Storage resources using shared access
signatures
(SAS)](https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview)
There are three types of SAS supported by Azure Storage:
> ABFS: [FNS Over Blob] Support User Delegation SAS for FNS Blob
> --------------------------------------------------------------
>
> Key: HADOOP-19406
> URL: https://issues.apache.org/jira/browse/HADOOP-19406
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> In ABFS Driver, user delegation SAS is currently only supported by
> hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR
> adds support for User Delegation SAS for non-HNS accounts over Blob endpoint
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
