[ 
https://issues.apache.org/jira/browse/HADOOP-19537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943450#comment-17943450
 ] 

ASF GitHub Bot commented on HADOOP-19537:
-----------------------------------------

stoty opened a new pull request, #7600:
URL: https://github.com/apache/hadoop/pull/7600

   ### Description of PR
   
   The command lines for Windows in BULIDING.txt don't work.
   This fixes them so that they work out of the box in the Windows build Docker 
 image.
   
   ### How was this patch tested?
   
   Ran the example command in the Windows build docker image
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Document skip.platformToolsetDetection option in BUILDING.txt
> -------------------------------------------------------------
>
>                 Key: HADOOP-19537
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19537
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Minor
>
> Readme.md has a complete command line example for builidng Hadoop on windows.
> However, that one doesn't work in the docker image, because that doesn't have 
> full visual studio install, and misses the expected programs.
> Add to README.md that the *-Dskip.platformToolsetDetection* maven option is 
> needed when building maven from the docker image.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to