[ 
https://issues.apache.org/jira/browse/HADOOP-19537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943464#comment-17943464
 ] 

ASF GitHub Bot commented on HADOOP-19537:
-----------------------------------------

hadoop-yetus commented on PR #7600:
URL: https://github.com/apache/hadoop/pull/7600#issuecomment-2796175410

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 19s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  shadedclient  |  24m 18s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shadedclient  |  20m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 23s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  46m 49s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.48 ServerAPI=1.48 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7600/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7600 |
   | Optional Tests | dupname asflicense codespell detsecrets |
   | uname | Linux 5b6a22ad8dc1 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 
17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / fe8fbe8b296b2e5a9ab7fef0e771d4a4dbe00e10 |
   | Max. process+thread count | 704 (vs. ulimit of 5500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7600/2/console |
   | versions | git=2.25.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Document skip.platformToolsetDetection option in BUILDING.txt
> -------------------------------------------------------------
>
>                 Key: HADOOP-19537
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19537
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Minor
>              Labels: pull-request-available
>
> Readme.md has a complete command line example for building Hadoop on Windows.
> However, that one doesn't work in the docker image, because that doesn't have 
> full Visual Studio install, and misses the expected programs.
> Add to README.md that the *-Dskip.platformToolsetDetection* maven option is 
> needed when building from the docker image.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to