[ 
https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987321#comment-17987321
 ] 

ASF GitHub Bot commented on HADOOP-19426:
-----------------------------------------

anujmodi2021 commented on code in PR #7757:
URL: https://github.com/apache/hadoop/pull/7757#discussion_r2179116426


##########
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java:
##########
@@ -71,22 +73,23 @@ public static Collection adlCreateNonRecursiveTestData()
     return datas;
   }
 
-  @AfterClass
+  @AfterAll
   public static void cleanUp() throws IOException, URISyntaxException {
     if (AdlStorageConfiguration.isContractTestEnabled()) {
-      Assert.assertTrue(AdlStorageConfiguration.createStorageConnector()
+      assertTrue(AdlStorageConfiguration.createStorageConnector()
           .delete(testRoot, true));
     }
   }
 
-  @Before

Review Comment:
   Do we need @BeforeEach here after removing @Before?





> Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.
> ---------------------------------------------------
>
>                 Key: HADOOP-19426
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19426
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, test
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to