[
https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987362#comment-17987362
]
ASF GitHub Bot commented on HADOOP-19426:
-----------------------------------------
slfan1989 commented on code in PR #7757:
URL: https://github.com/apache/hadoop/pull/7757#discussion_r2179392761
##########
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java:
##########
@@ -71,22 +73,23 @@ public static Collection adlCreateNonRecursiveTestData()
return datas;
}
- @AfterClass
+ @AfterAll
public static void cleanUp() throws IOException, URISyntaxException {
if (AdlStorageConfiguration.isContractTestEnabled()) {
- Assert.assertTrue(AdlStorageConfiguration.createStorageConnector()
+ assertTrue(AdlStorageConfiguration.createStorageConnector()
.delete(testRoot, true));
}
}
- @Before
Review Comment:
@anujmodi2021 Thank you for your question! ParameterizedTest in JUnit 5 is a
special type of unit test. Unlike JUnit 4, ParameterizedTest requires the
initialization of certain parameters directly in the test method, so the setup
function is executed at that point. If we add `@BeforeEach`, the variables in
`setup` would not be initialized yet. Therefore, we don't need to add
`@BeforeEach`; instead, we should call `setup` within
`initTestAdlPermissionLive`.
> Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.
> ---------------------------------------------------
>
> Key: HADOOP-19426
> URL: https://issues.apache.org/jira/browse/HADOOP-19426
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
