[ 
https://issues.apache.org/jira/browse/HADOOP-19610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009582#comment-18009582
 ] 

ASF GitHub Bot commented on HADOOP-19610:
-----------------------------------------

steveloughran commented on PR #7814:
URL: https://github.com/apache/hadoop/pull/7814#issuecomment-3113482749

   rebased and with core tests working, just some minor failures. Also new tag 
`@IntegrationTest` to declare that a suite is an integration test, adds test 
runner tag "integration".
   
   Failures now yarn minicluster and multipart.
   ```
   [ERROR] Errors: 
   [ERROR]   ITestS3AContractMultipartUploader.testConcurrentUploads » 
AWSStatus500 Completing multipart upload on 
job-00-fork-0007/test/testConcurrentUploads: 
software.amazon.awssdk.services.s3.model.S3Exception: We encountered an 
internal error. Please try again. (Service: S3, Status Code: 500, Request ID: 
A4Z5WRV9V3W74C5V, Extended Request ID: 
6m/CFanxXEWMLy8l+qBBQr+OMt6g9goM86k0WiHL66DRBZ0SkMhoaamAtR9tX+UVE8fyD2ddpCk=):InternalError:
 We encountered an internal error. Please try again. (Service: S3, Status Code: 
500, Request ID: A4Z5WRV9V3W74C5V, Extended Request ID: 
6m/CFanxXEWMLy8l+qBBQr+OMt6g9goM86k0WiHL66DRBZ0SkMhoaamAtR9tX+UVE8fyD2ddpCk=)   
                                                                                
                                              
   [ERROR]   
ITestS3AContractMultipartUploader.testMultipartUploadReverseOrderNonContiguousPartNumbers
 » AWSStatus500 Completing multipart upload on 
job-00-fork-0007/test/testMultipartUploadReverseOrderNonContiguousPartNumbers: 
software.amazon.awssdk.services.s3.model.S3Exception: We encountered an 
internal error. Please try again. (Service: S3, Status Code: 500, Request ID: 
DA6VS34DM5F80MBW, Extended Request ID: 
ovgd95kBya/OUd3NRGcN81Ls/GCUQW5D3uQ+hNz1DcKiKpIBZHWshGyeaXWv3awM4FJcSs4+5fQ=):InternalError:
 We encountered an internal error. Please try again. (Service: S3, Status Code: 
500, Request ID: DA6VS34DM5F80MBW, Extended Request ID: 
ovgd95kBya/OUd3NRGcN81Ls/GCUQW5D3uQ+hNz1DcKiKpIBZHWshGyeaXWv3awM4FJcSs4+5fQ=)   
                                                          
   [ERROR] 
org.apache.hadoop.fs.s3a.commit.integration.ITestS3ACommitterMRJob.test_200_execute(Path)
   [ERROR]   Run 1: ITestS3ACommitterMRJob.test_200_execute:280 » NullPointer 
Cannot read the array length because "blkLocations" is null
   [ERROR]   Run 2: ITestS3ACommitterMRJob.test_200_execute:280 » NullPointer 
Cannot read the array length because "blkLocations" is null
   [ERROR]   Run 3: ITestS3ACommitterMRJob.test_200_execute:280 » NullPointer 
Cannot read the array length because "blkLocations" is null
   [INFO] 
   ```
   
   I do suspect the multipart is related but I don't want it to hold up this 
(critical) patch.
   
   ITestS3ACommitterMRJob may be a test setup again as it is a sequence of 
tests.
   
   ```
   [INFO] Running 
org.apache.hadoop.fs.s3a.commit.integration.ITestS3ACommitterMRJob
   [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
1.756 s <<< FAILURE! 

> S3A: ITests to run under JUnit5
> -------------------------------
>
>                 Key: HADOOP-19610
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19610
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: 3.5.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> hadoop-aws tests which need to be parameterized on a class level
> are configured to do so through the @ParameterizedClass tag.
> Filesystem contract test suites in hadoop-common have
> also been parameterized as appropriate.
> There are custom JUnit tags declared in org.apache.hadoop.test.tags,
> which add tag strings to test suites/cases declaring them.
> They can be used on the command line and in IDEs to control
> which tests are/are not executed.
> @FlakyTest "flaky"
> @LoadTest "load"
> @RootFilesystemTest "rootfilesystem"
> @ScaleTest "scale"
> For anyone migrating tests to JUnit 5
> * Methods which subclass an existing test case MUST declare the @Test
>   tag again -it is no longer inherited.
> * All overridden setup/teardown methods MUST be located and
>   @BeforeEach/@AfterEach attribute added respectively
> * Subclasses of a parameterized test suite MUST redeclare themselves
>   as a @ParameterizedClass, and the binding mechanism again.
> * Parameterized test suites SHOULD declare a pattern to generate an
>   informative parameter value string for logs, IDEs and stack traces, e.g.
>   @ParameterizedClass(name="performance-{0}")
> * Test suites SHOULD add a org.apache.hadoop.test.tags tag to
>   declare what kind of test it is. These tags are inherited, so it
>   may be that only shared superclasses of test suites need to be tagged.
>   The abstract filesystem contract tests are NOT declared as integration
>   tests -implementations MUST do so if they are integration tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to