[ 
https://issues.apache.org/jira/browse/HADOOP-19610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009662#comment-18009662
 ] 

ASF GitHub Bot commented on HADOOP-19610:
-----------------------------------------

hadoop-yetus commented on PR #7814:
URL: https://github.com/apache/hadoop/pull/7814#issuecomment-3114347396

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 54s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 92 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   8m 20s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m  7s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m 25s |  |  trunk passed with JDK 
Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  13m 41s |  |  trunk passed with JDK 
Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09  |
   | +1 :green_heart: |  checkstyle  |   4m 23s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m  7s |  |  trunk passed with JDK 
Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   4m 45s |  |  trunk passed with JDK 
Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09  |
   | +1 :green_heart: |  spotbugs  |   8m 44s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  39m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 56s |  |  the patch passed with JDK 
Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  14m 56s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 30s |  |  the patch passed with JDK 
Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09  |
   | +1 :green_heart: |  javac  |  15m 30s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   4m 55s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7814/8/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 14 new + 76 unchanged - 19 fixed = 90 total (was 
95)  |
   | +1 :green_heart: |  mvnsite  |   5m 17s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   4m 13s |  |  the patch passed with JDK 
Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   4m 34s |  |  the patch passed with JDK 
Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09  |
   | +1 :green_heart: |  spotbugs  |   9m 18s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  36m 20s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  22m 44s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 139m 36s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   3m 43s |  |  hadoop-aws in the patch passed. 
 |
   | +1 :green_heart: |  unit  |   3m 13s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m 12s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 414m 42s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.51 ServerAPI=1.51 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7814/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7814 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 02a710867175 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 
19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 99198ef20b6947689534ecc76026b2bc5b4771f5 |
   | Default Java | Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7814/8/testReport/ |
   | Max. process+thread count | 3152 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws 
hadoop-tools/hadoop-azure U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7814/8/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> S3A: ITests to run under JUnit5
> -------------------------------
>
>                 Key: HADOOP-19610
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19610
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: 3.5.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> hadoop-aws tests which need to be parameterized on a class level
> are configured to do so through the @ParameterizedClass tag.
> Filesystem contract test suites in hadoop-common have
> also been parameterized as appropriate.
> There are custom JUnit tags declared in org.apache.hadoop.test.tags,
> which add tag strings to test suites/cases declaring them.
> They can be used on the command line and in IDEs to control
> which tests are/are not executed.
> @FlakyTest "flaky"
> @LoadTest "load"
> @RootFilesystemTest "rootfilesystem"
> @ScaleTest "scale"
> For anyone migrating tests to JUnit 5
> * Methods which subclass an existing test case MUST declare the @Test
>   tag again -it is no longer inherited.
> * All overridden setup/teardown methods MUST be located and
>   @BeforeEach/@AfterEach attribute added respectively
> * Subclasses of a parameterized test suite MUST redeclare themselves
>   as a @ParameterizedClass, and the binding mechanism again.
> * Parameterized test suites SHOULD declare a pattern to generate an
>   informative parameter value string for logs, IDEs and stack traces, e.g.
>   @ParameterizedClass(name="performance-{0}")
> * Test suites SHOULD add a org.apache.hadoop.test.tags tag to
>   declare what kind of test it is. These tags are inherited, so it
>   may be that only shared superclasses of test suites need to be tagged.
>   The abstract filesystem contract tests are NOT declared as integration
>   tests -implementations MUST do so if they are integration tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to