stoty commented on code in PR #7928:
URL: https://github.com/apache/hadoop/pull/7928#discussion_r2319677719
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml:
##########
@@ -144,6 +144,11 @@
<artifactId>jersey-media-jaxb</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
How did you decide where to add jaxb-imp and with what scope ?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/pom.xml:
##########
@@ -122,6 +122,12 @@
<artifactId>jersey-test-framework-provider-jetty</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.jaxb</groupId>
+ <artifactId>jaxb-runtime</artifactId>
+ <version>${jaxb.version}</version>
Review Comment:
The version should be set in once in the hadoop-project pom
dependencyManagement section
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml:
##########
@@ -208,6 +208,12 @@
<artifactId>jersey-media-json-jettison</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.jaxb</groupId>
+ <artifactId>jaxb-runtime</artifactId>
+ <version>${jaxb.version}</version>
+ <scope>test</scope>
Review Comment:
This is needed by Jetty. (at least)
This should be compile scope, as javax.xml.bind is directly used in the main
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
