stoty commented on code in PR #7928:
URL: https://github.com/apache/hadoop/pull/7928#discussion_r2321030300


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml:
##########
@@ -208,6 +208,12 @@
       <artifactId>jersey-media-json-jettison</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.glassfish.jaxb</groupId>
+      <artifactId>jaxb-runtime</artifactId>
+      <version>${jaxb.version}</version>
+      <scope>test</scope>

Review Comment:
   > I was not sure this needed in every case for the Jetty.
   
   The stack strace seems to be coming from Jetty initialization.
   
   > But in that case if i see well we will need this every where where we are 
using the HttpServer2. So if i see well this will be needed in HDFS NN also.
   
   Yes, that's likely.
   
   > 
   > In that case shall we add this to the `hadoop-common` project only and let 
others use it transitively?
   
   I think it's better to add it separately where needed.
   Most modules don't use Jetty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to