[ 
https://issues.apache.org/jira/browse/HADOOP-19605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040239#comment-18040239
 ] 

ASF GitHub Bot commented on HADOOP-19605:
-----------------------------------------

pan3793 commented on PR #8078:
URL: https://github.com/apache/hadoop/pull/8078#issuecomment-3569406778

   @slfan1989 none of these are required.
   
   IIRC, previously we had a conclusion on how to maintain those `Dockerfile`s:
   - keep them up to date for trunk
   - for released branches, e.g. `branch-3.4`, keep `Dockerfile`s permanently 
on the source tree, and disable them from the Jenkins pipeline once it reaches 
EOL and breaks the CI
   
   In branch-3.4, there are 4 `Dockerfile`s and all in Jenkins pipeline - 
`ubuntu_focal`, `centos_7`, `centos_8`, `debian_10`, I think the right thing 
here is:
   - disable `centos_7` on Jenkins pipeline (broken due to old version of glibc 
does not work with `protobuf` used by Hadoop Java, thus breaks the build) 
   - disable `debian_10` on Jenkins pipeline (broken due to APT repo sunset)
   - `ubuntu_focal` passes CI
   - `centos_8` also keeps working, I tested it manually
   
   BTW, disabling `centos_7` and `debian_10` from the Jenkins pipeline is 
orthogonal to this PR because they were broken due to different reasons without 
a relationship to this one.




> Upgrade Protobuf 3.25.5 for docker images
> -----------------------------------------
>
>                 Key: HADOOP-19605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19605
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.2
>            Reporter: Cheng Pan
>            Assignee: Cheng Pan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> HADOOP-19289 upgraded protobuf-java 3.25.5, we should use same version for 
> protobuf installed in docker images.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to