[ 
https://issues.apache.org/jira/browse/HADOOP-19805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056935#comment-18056935
 ] 

ASF GitHub Bot commented on HADOOP-19805:
-----------------------------------------

steveloughran opened a new pull request, #8232:
URL: https://github.com/apache/hadoop/pull/8232

   
   
   This makes it a lot easier to configure a signer, rather than the full 
AwsSignerInitializer interface, which is only applied when you have a chain of 
custom signers.
   
   
   ### How was this patch tested?
   
   S3 london
   
   * all tests have passed.
   * this shows that branch-3.4 is lacking; there's one commit I will pull in 
and should have already #8118 ; dir marker and yarn stuff I'm going to neglect.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [X] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html
   
   no ai: humans shall be free!




> When creating a signer, if it is Configurable, set its config
> -------------------------------------------------------------
>
>                 Key: HADOOP-19805
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19805
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.4.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> When creating a signer for s3 (or another service), if it is Configurable, 
> call setConf() on it.
> This comes from me wiring s3a up to iceberg RestCatalog; it's pretty 
> convoluted to connect a signer in the sdk to its owner fs otherwise, and so 
> get the configuration for that bucket. Trivial change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to