[
https://issues.apache.org/jira/browse/HADOOP-19805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056938#comment-18056938
]
ASF GitHub Bot commented on HADOOP-19805:
-----------------------------------------
steveloughran commented on code in PR #8232:
URL: https://github.com/apache/hadoop/pull/8232#discussion_r2774800484
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java:
##########
@@ -124,7 +128,10 @@ public static Signer createSigner(String signerType,
String configKey) throws IO
Signer signer =
S3AUtils.getInstanceFromReflection(className, null, null,
Signer.class, "create",
configKey);
-
+ requireNonNull(conf);
+ if (signer instanceof Configurable sc) {
Review Comment:
fancy java17 feature here
> When creating a signer, if it is Configurable, set its config
> -------------------------------------------------------------
>
> Key: HADOOP-19805
> URL: https://issues.apache.org/jira/browse/HADOOP-19805
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> When creating a signer for s3 (or another service), if it is Configurable,
> call setConf() on it.
> This comes from me wiring s3a up to iceberg RestCatalog; it's pretty
> convoluted to connect a signer in the sdk to its owner fs otherwise, and so
> get the configuration for that bucket. Trivial change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
