pan3793 commented on code in PR #8399:
URL: https://github.com/apache/hadoop/pull/8399#discussion_r3032099685
##########
hadoop-client-modules/hadoop-client-api/pom.xml:
##########
@@ -67,13 +67,17 @@
</exclusion>
</exclusions>
</dependency>
- <!-- snappy-java is native library and cannot be relocated. So we
explicitly exclude it
- from shaded jar to prevent possible conflict. Make it as transitive
dependency to
- make the downstream pull it. -->
+ <!-- snappy-java/zstd-jni contains native library and cannot be relocated.
+ So we explicitly exclude it from shaded jar to prevent possible
conflict.
+ Declare it as transitive dependency to make the downstream pull it.
-->
Review Comment:
in short, handling `zst-jni` in the same way as `snappy-java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
