aajisaka commented on code in PR #8399:
URL: https://github.com/apache/hadoop/pull/8399#discussion_r3038237356
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/ZStandardCodec.java:
##########
@@ -59,30 +58,8 @@ public Configuration getConf() {
return conf;
}
- public static void checkNativeCodeLoaded() {
- if (!NativeCodeLoader.isNativeCodeLoaded() ||
- !NativeCodeLoader.buildSupportsZstd()) {
- throw new RuntimeException("native zStandard library "
- + "not available: this version of libhadoop was built "
- + "without zstd support.");
- }
- if (!ZStandardCompressor.isNativeCodeLoaded()) {
- throw new RuntimeException("native zStandard library not "
- + "available: ZStandardCompressor has not been loaded.");
- }
- if (!ZStandardDecompressor.isNativeCodeLoaded()) {
- throw new RuntimeException("native zStandard library not "
- + "available: ZStandardDecompressor has not been loaded.");
- }
- }
-
- public static boolean isNativeCodeLoaded() {
Review Comment:
This class is not `@Public`, so I think it's okay to remove.
I saw 1 external usage in GitHub:
https://github.com/trinodb/trino-hadoop-apache/blob/a1db88d0d14e4331034db0bcfb2dbc61d807db74/src/test/java/io/trino/hadoop/TestHadoopNative.java#L51.
It's test only and it does not actually verify the zstd support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
