[ 
https://issues.apache.org/jira/browse/HADOOP-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071414#comment-18071414
 ] 

ASF GitHub Bot commented on HADOOP-19855:
-----------------------------------------

hadoop-yetus commented on PR #8399:
URL: https://github.com/apache/hadoop/pull/8399#issuecomment-4192099970

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m  0s |  |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m 15s |  |  
https://github.com/apache/hadoop/pull/8399 does not apply to trunk. Rebase 
required? Wrong Branch? See 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.  
|
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/7/console |
   | versions | git=2.34.1 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Use zstd-jni in ZStandardCodec
> ------------------------------
>
>                 Key: HADOOP-19855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19855
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: compress
>    Affects Versions: 3.5.0
>            Reporter: Cheng Pan
>            Priority: Major
>              Labels: pull-request-available
>
> In Hadoop, we use native libs for zstd codec which has several disadvantages:
>  * It requires native *libhadoop* and *libzstd* to be installed in system 
> {*}LD_LIBRARY_PATH{*}, and they have to be installed separately on each node 
> of the clusters, container images, or local test environments which adds huge 
> complexities from deployment point of view. In some environments, it requires 
> compiling the natives from sources which is non-trivial. Also, this approach 
> is platform dependent; the binary may not work in different platform, so it 
> requires recompilation.
>  * It requires extra configuration of *java.library.path* to load the 
> natives, and it results higher application deployment and maintenance cost 
> for users.
> Projects such as *Spark* and *Parquet* use 
> [zstd-jni|https://github.com/luben/zstd-jni] which is JNI-based 
> implementation. It contains native binaries for Linux, Mac, and IBM in jar 
> file, and it can automatically load the native binaries into JVM from jar 
> without any setup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to