[ 
https://issues.apache.org/jira/browse/HADOOP-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071833#comment-18071833
 ] 

ASF GitHub Bot commented on HADOOP-19855:
-----------------------------------------

hadoop-yetus commented on PR #8399:
URL: https://github.com/apache/hadoop/pull/8399#issuecomment-4203278207

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   7m 30s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +0 :ok: |  jsonlint  |   0m  1s |  |  jsonlint was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m 14s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   8m 22s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 44s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   8m 53s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m  0s |  |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 15s |  |  branch/hadoop-project-dist no 
spotbugs output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 17s |  |  
branch/hadoop-client-modules/hadoop-client-api no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 15s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 17s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | -1 :x: |  spotbugs  |  18m 37s | 
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/artifact/out/branch-spotbugs-root-warnings.html)
 |  root in trunk has 92 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  33m 45s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  28m 23s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 22s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   8m 22s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   8m 22s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   8m 22s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 53s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 
56)  |
   | +1 :green_heart: |  hadolint  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  mvnsite  |   8m 57s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 58s |  |  the patch passed  |
   | +0 :ok: |  spotbugs  |   0m 15s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 15s |  |  hadoop-project-dist has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
hadoop-client-modules/hadoop-client-api has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 15s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  33m 47s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  | 742m 13s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/artifact/out/patch-unit-root.txt)
 |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m  4s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 930m 58s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | 
hadoop.hdfs.server.federation.router.async.TestRouterAsyncRpcClient |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | 
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
 |
   |   | 
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun |
   |   | 
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
 |
   |   | hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown 
|
   |   | 
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps |
   |   | hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown 
|
   |   | 
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageSchema |
   |   | 
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain |
   |   | 
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities |
   |   | 
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8399 |
   | Optional Tests | dupname asflicense codespell detsecrets hadolint 
shellcheck shelldocs mvnsite unit jsonlint compile javac javadoc mvninstall 
shadedclient xmllint cc spotbugs checkstyle golang |
   | uname | Linux 143b389add1d 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 
21:35:19 UTC 2025 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 7641c63c397e109d72cf21e26db5f33ee4989de9 |
   | Default Java | Debian-25.0.2+10-Debian-1deb13u2 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/testReport/ |
   | Max. process+thread count | 4371 (vs. ulimit of 10000) |
   | modules | C: hadoop-project hadoop-project-dist 
hadoop-common-project/hadoop-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
 hadoop-client-modules/hadoop-client-api 
hadoop-client-modules/hadoop-client-runtime 
hadoop-client-modules/hadoop-client-minicluster 
hadoop-client-modules/hadoop-client-check-invariants 
hadoop-client-modules/hadoop-client-check-test-invariants . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8399/8/console |
   | versions | git=2.47.3 maven=3.9.11 hadolint=1.11.1-0-g0e692dd 
spotbugs=4.9.7 shellcheck=0.10.0 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Use zstd-jni in ZStandardCodec
> ------------------------------
>
>                 Key: HADOOP-19855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19855
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: compress
>    Affects Versions: 3.5.0
>            Reporter: Cheng Pan
>            Priority: Major
>              Labels: pull-request-available
>
> In Hadoop, we use native libs for zstd codec which has several disadvantages:
>  * It requires native *libhadoop* and *libzstd* to be installed in system 
> {*}LD_LIBRARY_PATH{*}, and they have to be installed separately on each node 
> of the clusters, container images, or local test environments which adds huge 
> complexities from deployment point of view. In some environments, it requires 
> compiling the natives from sources which is non-trivial. Also, this approach 
> is platform dependent; the binary may not work in different platform, so it 
> requires recompilation.
>  * It requires extra configuration of *java.library.path* to load the 
> natives, and it results higher application deployment and maintenance cost 
> for users.
> Projects such as *Spark* and *Parquet* use 
> [zstd-jni|https://github.com/luben/zstd-jni] which is JNI-based 
> implementation. It contains native binaries for Linux, Mac, and IBM in jar 
> file, and it can automatically load the native binaries into JVM from jar 
> without any setup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to