pan3793 commented on code in PR #8412: URL: https://github.com/apache/hadoop/pull/8412#discussion_r3055199351
########## .github/workflows/build_only_trunk_debian_13.yml: ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build (trunk, Java 25, Debian 13)" + +on: + push: + branches: + - trunk + - branch-* + pull_request_target: Review Comment: @ajfabbri since we run CI inside a container, we need to build the image in one job, and use it in another, if we use "pull_request", it does not have "packages write" permission, thus it will fail in the push image phase. Spark does not face this issue because it actually runs all CI jobs in the forked repo, and uses a script to query and sync the status of those jobs in the PR checks, this is a relatively complex setup, but it does solve the permission and security issue. I'm still exploring other approaches to share docker image across jobs, if we don't need to write it to GH repo "packages", we can change it back to "pull_request" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
