ajfabbri commented on code in PR #8412: URL: https://github.com/apache/hadoop/pull/8412#discussion_r3066794218
########## .github/workflows/build_only_trunk_debian_13.yml: ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build (trunk, Java 25, Debian 13)" + +on: + push: + branches: + - trunk + - branch-* + pull_request_target: Review Comment: I've been to busy today to dig into how the spark CI works, or understand any other options available. I am excited to see progress though! I think we should: - Proceed iteratively. We should feel free to try out different approaches. We can rewrite it if we think of something better, etc. - Err on the side of caution for security, since GH Actions are such a difficult thing to secure for public repos. We could get something committed that only works for those with write access to our repo (i.e. committers) and iterate on it (make it fast & stable), and then implement the extra complexity for security when we're ready to open it up to all PRs (i.e. forks). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
