deepujain commented on PR #8306: URL: https://github.com/apache/hadoop/pull/8306#issuecomment-4240314626
Addressed the current review feedback and force-pushed the branch. The optimized non-empty-directory path now sends `x-amz-delete-contents: true` only on that delete request instead of relying on a global `fs.s3a.client.s3.custom.headers` setting, the capability test no longer duplicates `AbstractContractDeleteTest`, and it now creates isolated filesystems after removing bucket/base overrides so user preset values do not leak into the assertions. I also fixed the delete debug logging to distinguish files from dir markers, and updated the docs to describe the request-scoped header behavior. Local validation passed with `JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home /opt/homebrew/bin/mvn -Dmaven.repo.local=/tmp/codex-m2 test -pl hadoop-tools/hadoop-aws -am -Dtest=TestRequestFactory -DskipTests=false` (12 tests, 0 failures). I was not able to rerun against a VAST endpoint from here, so that endpoint-specific integration path remains unverified locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
