[
https://issues.apache.org/jira/browse/HADOOP-19801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073315#comment-18073315
]
ASF GitHub Bot commented on HADOOP-19801:
-----------------------------------------
deepujain commented on PR #8306:
URL: https://github.com/apache/hadoop/pull/8306#issuecomment-4240314626
Addressed the current review feedback and force-pushed the branch. The
optimized non-empty-directory path now sends `x-amz-delete-contents: true` only
on that delete request instead of relying on a global
`fs.s3a.client.s3.custom.headers` setting, the capability test no longer
duplicates `AbstractContractDeleteTest`, and it now creates isolated
filesystems after removing bucket/base overrides so user preset values do not
leak into the assertions. I also fixed the delete debug logging to distinguish
files from dir markers, and updated the docs to describe the request-scoped
header behavior. Local validation passed with
`JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home
/opt/homebrew/bin/mvn -Dmaven.repo.local=/tmp/codex-m2 test -pl
hadoop-tools/hadoop-aws -am -Dtest=TestRequestFactory -DskipTests=false` (12
tests, 0 failures). I was not able to rerun against a VAST endpoint from here,
so that endpoint-specific integration path remains unverified locally.
> Allow to skip recursive file deletion for non-empty directory
> -------------------------------------------------------------
>
> Key: HADOOP-19801
> URL: https://issues.apache.org/jira/browse/HADOOP-19801
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/s3
> Reporter: Enrico Minack
> Priority: Major
> Labels: pull-request-available
>
> A non-empty directory, as well as a directory where its emptiness is unknown,
> is deleted by listing all contained files (or objects with matching key
> prefix), then deleting those files (objects) in bulk delete requests, and
> finally deleting the (then) empty directory itself.
> The recursive deletion of objects is not needed for S3 endpoints that support
> deleting non-empty directories (or path prefixes).
> For example: The [VAST S3 endpoint supports deleting non-empty
> directories|https://kb.vastdata.com/documentation/docs/using-trash-folder-for-s3-objects-6]
> with a single request. Such a feature can only be fully leveraged if
> {{hadoop-aws}} coupd skip the recursive deletion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
