[
https://issues.apache.org/jira/browse/HADOOP-19801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073500#comment-18073500
]
ASF GitHub Bot commented on HADOOP-19801:
-----------------------------------------
deepujain commented on PR #8306:
URL: https://github.com/apache/hadoop/pull/8306#issuecomment-4244850453
Addressed the new review point and force-pushed. This revision removes the
hardcoded proprietary delete header from S3A, adds generic request-type custom
header support (fs.s3a.client.{s3,sts}.custom.headers.request.REQUEST), and
updates the non-empty-directory delete docs to use request-scoped configuration
when an endpoint needs extra headers. Local validation passed with
JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home
PATH=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home/bin:$PATH
/opt/homebrew/bin/mvn -Dmaven.repo.local=/tmp/codex-m2 test -pl
hadoop-tools/hadoop-aws -am -Dtest=TestAwsClientConfig,TestRequestFactory
-DskipTests=false (20 tests, 0 failures).
> Allow to skip recursive file deletion for non-empty directory
> -------------------------------------------------------------
>
> Key: HADOOP-19801
> URL: https://issues.apache.org/jira/browse/HADOOP-19801
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/s3
> Reporter: Enrico Minack
> Priority: Major
> Labels: pull-request-available
>
> A non-empty directory, as well as a directory where its emptiness is unknown,
> is deleted by listing all contained files (or objects with matching key
> prefix), then deleting those files (objects) in bulk delete requests, and
> finally deleting the (then) empty directory itself.
> The recursive deletion of objects is not needed for S3 endpoints that support
> deleting non-empty directories (or path prefixes).
> For example: The [VAST S3 endpoint supports deleting non-empty
> directories|https://kb.vastdata.com/documentation/docs/using-trash-folder-for-s3-objects-6]
> with a single request. Such a feature can only be fully leveraged if
> {{hadoop-aws}} coupd skip the recursive deletion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
