[ 
https://issues.apache.org/jira/browse/HADOOP-19869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075552#comment-18075552
 ] 

ASF GitHub Bot commented on HADOOP-19869:
-----------------------------------------

steveloughran opened a new pull request, #8453:
URL: https://github.com/apache/hadoop/pull/8453

   
   ### Description of PR
   
   
   HADOOP-19869 Modernize secret manager default algorithm and key length
      
   HmacSHA256 and 256 bits.
   
   Also import directly the algorithm in different modules, so it is consistent.
   
   Contains content generated by Coplot + Claude Sonnet 4.6
   
   ### How was this patch tested?
   
   updated test
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [X] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [X] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html




> Modernize secret manager default algorithm and key length
> ---------------------------------------------------------
>
>                 Key: HADOOP-19869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19869
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.5.0, 3.4.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>
> While doing other cleanup, I've noticed that the default checksum algorithm 
> and key length for generating secrets (block tokens, job tokens) are out of 
> date by modern standards. Not broken, just weak.
> Change the defaults to sha256 and 256 bits.
> Note that Sha 256 is becoming more vulnerable; not worrying about that as 
> these are ephemeral secrets
> [https://stateofutopia.com/papers/2/we-broke-92-percent-of-sha-256.html]
> This is the same as setting
> {{hadoop.security.secret-manager.key-length 256}}
> {{hadoop.security.secret-manager.key-generator.algorithm HmacSHA256}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to