[
https://issues.apache.org/jira/browse/HADOOP-19869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075756#comment-18075756
]
ASF GitHub Bot commented on HADOOP-19869:
-----------------------------------------
cnauroth commented on PR #8453:
URL: https://github.com/apache/hadoop/pull/8453#issuecomment-4306289152
> only one I am worried about is HDFS and rolling upgrades. Does a change to
keylength/algorithm for new shared secrets cause problems?
This is the situation I had in mind. `SecretManager` wraps a
`javax.crypto.Mac`, and it only knows how to create it with one specific
algorithm.
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/SecretManager.java#L255
If we have some HmacSHA1 tokens in flight, and then we restart NameNode with
the new configuration, will it start trying to verify the old tokens as
HmacSHA1 and hit password mismatches here?
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java#L660-L663
> Modernize secret manager default algorithm and key length
> ---------------------------------------------------------
>
> Key: HADOOP-19869
> URL: https://issues.apache.org/jira/browse/HADOOP-19869
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.5.0, 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
>
> While doing other cleanup, I've noticed that the default checksum algorithm
> and key length for generating secrets (block tokens, job tokens) are out of
> date by modern standards. Not broken, just weak.
> Change the defaults to sha256 and 256 bits.
> Note that Sha 256 is becoming more vulnerable; not worrying about that as
> these are ephemeral secrets
> [https://stateofutopia.com/papers/2/we-broke-92-percent-of-sha-256.html]
> This is the same as setting
> {{hadoop.security.secret-manager.key-length 256}}
> {{hadoop.security.secret-manager.key-generator.algorithm HmacSHA256}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
