[ 
https://issues.apache.org/jira/browse/HADOOP-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093121#comment-18093121
 ] 

ASF GitHub Bot commented on HADOOP-19922:
-----------------------------------------

Hexiaoqiao commented on code in PR #8553:
URL: https://github.com/apache/hadoop/pull/8553#discussion_r3510493298


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2524,6 +2525,10 @@ private void checkDataLength(int dataLength) throws 
IOException {
             maxDataLength + ".  RPC came from " + getHostAddress();
         LOG.warn(error);
         throw new IOException(error);
+      } else if (warnDataLength > 0 && dataLength > warnDataLength) {
+        LOG.warn(

Review Comment:
   Thanks. I believe this is useful for end user, but I don't think it is 
necessary to add another configuration item to support this. What about leave 
log when data length is over half of max response length? Thanks again.





> Add configurable warn threshold for large IPC RPC request data length
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-19922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19922
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: dzcxzl
>            Priority: Minor
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to