[
https://issues.apache.org/jira/browse/HADOOP-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094491#comment-18094491
]
ASF GitHub Bot commented on HADOOP-19922:
-----------------------------------------
cxzl25 commented on code in PR #8553:
URL: https://github.com/apache/hadoop/pull/8553#discussion_r3541223343
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2524,6 +2525,10 @@ private void checkDataLength(int dataLength) throws
IOException {
maxDataLength + ". RPC came from " + getHostAddress();
LOG.warn(error);
throw new IOException(error);
+ } else if (warnDataLength > 0 && dataLength > warnDataLength) {
+ LOG.warn(
Review Comment:
1. Different purpose: the max length is a hard limit (reject), the warn
threshold is just a heads-up (notice).
2. Different clusters, different norms: what's "too big" varies by workload.
A fixed ratio can't fit everyone — a separate config can.
3. Need an off switch: operators may want to silence the warning without
touching the hard limit. -1 gives a clean way to do that.
> Add configurable warn threshold for large IPC RPC request data length
> ---------------------------------------------------------------------
>
> Key: HADOOP-19922
> URL: https://issues.apache.org/jira/browse/HADOOP-19922
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: dzcxzl
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
