[ 
https://issues.apache.org/jira/browse/HADOOP-19951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18103622#comment-18103622
 ] 

ASF GitHub Bot commented on HADOOP-19951:
-----------------------------------------

pan3793 commented on code in PR #8654:
URL: https://github.com/apache/hadoop/pull/8654#discussion_r3756956035


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java:
##########
@@ -269,6 +270,7 @@ public boolean equals(Object obj) {
   @Override
   public int hashCode() {return toShort();}
 
+  @JsonValue // For Jackson serialization, use the toString() to represent 
this object as JSON.

Review Comment:
   It's exposing the Jackson API from the Hadoop API, I'm not sure this is a 
good choice ...





> Drop use of jetty-util-ajax and use jackson instead
> ---------------------------------------------------
>
>                 Key: HADOOP-19951
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19951
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: PJ Fanning
>            Priority: Major
>              Labels: pull-request-available
>
> Hadoop uses jetty-util-ajax in a few modules to read and write JSON.
> This is a part of HADOOP-19912 that can be split out and it doesn't cause the 
> same issues with worrying about jar compatibilities - it actually simplifies 
> the build by removing a direct dependency.
> The aim here is to reduce the number of ways that Hadoop works with JSON and 
> Jackson is more commonly used in Hadoop than jetty-util-ajax.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to