shoemoney commented on PR #8705:
URL: https://github.com/apache/hadoop/pull/8705#issuecomment-5468565276
CI came back on the test commit. `test4tests` flipped to +1 and `unit`
passed the whole
`hadoop-yarn-server-nodemanager` module (+1, 22m 58s), so the coverage gap
@slfan1989 raised
is closed and verified in CI, not just locally.
The two remaining -1s are not from this patch — they are identical to the
run *before* the
test existed:
| check | run 1 (pre-test) | run 2 (with test) |
|---|---|---|
| spotbugs | -1, `branch-spotbugs-...-nodemanager-warnings.html` | -1, same
`branch-spotbugs` artifact |
| asflicense | -1, 1 warning | -1, 1 warning |
- **spotbugs** is a `branch-` artifact, i.e. the trunk baseline, not a patch
finding.
- **asflicense** resolves to the same single pre-existing file in both runs,
in an unrelated
module:
`hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java:1:Missing
Apache License`.
Nothing in this PR touches hadoop-hdfs-rbf.
So the only delta between the two runs is test4tests going -1 -> +1. Happy
to take further
review whenever you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
