shoemoney commented on PR #8705: URL: https://github.com/apache/hadoop/pull/8705#issuecomment-5859621575
The three `-1`s on the latest Yetus run are all pre-existing trunk conditions rather than anything this patch introduces, so noting them here to save a reviewer the check: - **`unit` is `+1`**: `hadoop-yarn-server-nodemanager in the patch passed`. - **`spotbugs -1` is against the branch, not the patch.** The report reads `hadoop-yarn-server-nodemanager in trunk has 1 extant spotbugs warnings`. - **`asflicense -1` is one warning outside this patch**, in `hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java`. That file is vendored Jetty code carrying an EPL 1.0 plus Apache 2.0 header rather than the standard ASF header, it is unmodified on trunk today, and it sits in hadoop-hdfs-rbf. This patch touches only two files, both under hadoop-yarn-server-nodemanager. Happy to rebase onto current trunk if a fresh run would help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
