Hexiaoqiao commented on PR #8688: URL: https://github.com/apache/hadoop/pull/8688#issuecomment-5727049803
> @Hexiaoqiao Token verify/renew/cancel are not affected: `getTokenInfo` and `getDelegationKey` fall back to ZK on a cache miss. The in-memory load exists for the expired-token remover, which only scans `currentTokens` ([HADOOP-13487](https://issues.apache.org/jira/browse/HADOOP-13487)). That relied on PathChildrenCache `BUILD_INITIAL_CACHE` being synchronous; [HADOOP-17835](https://issues.apache.org/jira/browse/HADOOP-17835) (3.4.0) switched to `CuratorCache.start()`, which is asynchronous. The listener still fills the map a few seconds later, so the lasting effects are: token owner stats (Router `getTopTokenRealOwners`) are computed from a partial map and never corrected for pre-restart tokens, the root container znode is parsed on every startup and logs an ERROR, and `testNodesLoadedAfterRestart` is flaky in CI. Router with the token watcher disabled uses its own synchronous `rebuildTokenCache` and is unaffected. Retitled the PR and rewrote the description accordingly. Got it. LGTM. Give my +1 for this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
