[ 
https://issues.apache.org/jira/browse/HADOOP-19992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118315#comment-18118315
 ] 

ASF GitHub Bot commented on HADOOP-19992:
-----------------------------------------

hadoop-yetus commented on PR #8750:
URL: https://github.com/apache/hadoop/pull/8750#issuecomment-5793264560

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  19m 23s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  1s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  49m 39s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 49s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  compile  |   0m 49s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  checkstyle  |   0m 49s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 52s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 51s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javadoc  |   0m 48s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  spotbugs  |   1m  8s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  34m 39s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  |  the patch passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javac  |   0m 21s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 20s |  |  the patch passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  javac  |   0m 20s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 17s | 
[/results-checkstyle-hadoop-tools_hadoop-aliyun.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-aliyun.txt)
 |  hadoop-tools/hadoop-aliyun: The patch generated 1 new + 1 unchanged - 0 
fixed = 2 total (was 1)  |
   | +1 :green_heart: |  mvnsite  |   0m 22s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 21s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt)
 |  hadoop-tools_hadoop-aliyun-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu generated 4 new + 115 unchanged - 0 fixed = 
119 total (was 115)  |
   | -1 :x: |  javadoc  |   0m 21s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt)
 |  hadoop-tools_hadoop-aliyun-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu generated 4 new + 112 unchanged - 0 fixed = 
116 total (was 112)  |
   | +1 :green_heart: |  spotbugs  |   0m 48s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  33m 49s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 25s |  |  hadoop-aliyun in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 150m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.56 ServerAPI=1.56 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8750 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint 
|
   | uname | Linux 3b676b918fb4 5.15.0-185-generic #195-Ubuntu SMP Fri Jun 19 
17:11:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 173db43f3c7a9594d8cb3ac1a56006abf2990461 |
   | Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/testReport/ |
   | Max. process+thread count | 583 (vs. ulimit of 10000) |
   | modules | C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8750/1/console |
   | versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> AliyunOSS: Retry OSS multipart completion on QpsLimitExceeded
> -------------------------------------------------------------
>
>                 Key: HADOOP-19992
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19992
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/oss
>    Affects Versions: 3.4.3
>            Reporter: JunboWang
>            Priority: Minor
>              Labels: pull-request-available
>
> In hadoop-aliyun, CompleteMultipartUpload is not retried by the OSS Java 
> SDK's default policy. A QpsLimitExceeded response can therefore fail an 
> output stream close or multipart copy. Increasing fs.oss.attempts.maximum 
> does not resolve this.
> Proposed change:
> - Share completion retry logic between multipart uploads and copies.
> - Retry only QpsLimitExceeded, with exponential backoff and jitter capped at 
> 10 seconds. Add fs.oss.multipart.complete.retry.limit (default: 3 retries 
> after the initial attempt) and fs.oss.multipart.complete.retry.interval 
> (default: 500 ms). Propagate the failure when retries are exhausted.
> - Do not treat NoSuchUpload or an existing object alone as proof of success 
> if a completion response is lost.
> - Add regression tests in existing test classes for recovery, retry 
> exhaustion, non-retryable errors, and uncertain completion. No new 
> dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to