Hean-Chhinling commented on code in PR #8766:
URL: https://github.com/apache/hadoop/pull/8766#discussion_r4348582670
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-app/info.js:
##########
@@ -19,12 +19,40 @@
import Ember from 'ember';
export default Ember.Controller.extend({
+ applicationDiagnostic: Ember.inject.service('application-diagnostic'),
+
queryParams: ["service"],
service: undefined,
isLoading: false,
actionResponse: null,
+ isCollectingApplicationDiagnostic: false,
+ diagnosticCollectError: null,
Review Comment:
Thank you for the suggestion! It seems like the in-flight request's finally
could cause a problem.
If a collection on app B has started while A is still going. Then A's
finally will clear B's spinner and re-enabled the app's B button while it is
still collecting. This is also appA error handler will show on appB page.
I will fix on of this in my next commit with by giving id to the app request
and only update the page if the id is the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
