Hean-Chhinling commented on code in PR #8766: URL: https://github.com/apache/hadoop/pull/8766#discussion_r4348383635
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/services/application-diagnostic.js: ########## @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import Ember from 'ember'; +import { + buildBundleFolderName, + buildDiagnosticArchiveEntries, + buildDiagnosticZipBlob, +} from '../utils/diagnostic-archive'; + +const ISSUE_ID = 'application_diagnostic'; +const COLLECT_TIMEOUT_MS = 300000; + +export default Ember.Service.extend({ + hosts: Ember.inject.service('hosts'), + env: Ember.inject.service('env'), + + buildCollectUrl(appId) { + const host = this.get('hosts.rmWebAddress'); + const namespace = this.get('env.app.namespaces.cluster'); + const base = `${host}/${namespace}/common-issues/collect`; + const query = `issueId=${encodeURIComponent(ISSUE_ID)}&args=${encodeURIComponent(appId)}`; + return `${base}?${query}`; + }, + + collectApplicationDiagnostic(appId) { + const url = this.buildCollectUrl(appId); + + return new Ember.RSVP.Promise((resolve, reject) => { + Ember.$.ajax({ + url, + method: 'GET', + dataType: 'json', + timeout: COLLECT_TIMEOUT_MS, + crossDomain: true, + xhrFields: { + withCredentials: true + }, + headers: { + Accept: 'application/json' + }, + success: (payload) => resolve(payload), + error: (jqXHR) => reject(this.parseAjaxError(jqXHR)) Review Comment: You have a very good eye, @joseluisll! I will update this in my next commit along with a unit-test to make sure the timeout shows different error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
