[
https://issues.apache.org/jira/browse/HADOOP-20012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134768#comment-18134768
]
ASF GitHub Bot commented on HADOOP-20012:
-----------------------------------------
joseluisll opened a new pull request, #8890:
URL: https://github.com/apache/hadoop/pull/8890
### Description of PR
Part of HADOOP-19912 (Jetty 12 on ee8): split out of #8699, where it was
reviewed.
The catalog-webapp tests reach Solr only through `EmbeddedSolrServer`, which
runs no servlet container, but Solr brought its own Jetty (9.4.44) and servlet
API onto the test classpath next to `${jetty.version}`.
- catalog-webapp: `solr-test-framework` already depends on `solr-core`
(where `EmbeddedSolrServer` and `NodeConfig` live), so the direct `solr-core`
declaration goes, and `solr-test-framework` is the only Solr test dependency.
It carries the single exclusion list: Solr's Jetty modules (`jetty-io`, `-xml`,
`-http`, `-client`, `-alpn-*`, `-continuation`, `-deploy`, `-jmx`, `-rewrite`,
`-security`, `-servlets`, `http2-*`), `javax.servlet-api`,
`commons-collections` and `jcl-over-slf4j`. A Solr upgrade that adds a Jetty
artifact now needs one entry (review on #8699).
- `jetty-alpn-java-client`: Solr declares 9.4.44, and the managed 9.4.58
copy won only through Maven's declaration-order tie-break. It is excluded, as
`solr-solrj` already does.
- timelineservice-hbase-tests: on `hbase-server` and `hbase-server:tests`,
exclude `javax.servlet:javax.servlet-api`, as `hbase-server-2` already does.
Test scope only; nothing changes for production or downstream projects.
### How was this patch tested?
- `dependency:list` (test scope) of catalog-webapp: 238 artifacts.
`solr-core` 8.11.2 is still at test scope, all Jetty jars are at
`${jetty.version}` (9.4.58), and there is no `javax.servlet-api` 3.1.0.
- With the single exclusion list, the list is identical to the one with the
exclusions repeated on both Solr artifacts.
### For code changes:
- [x] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint declared according to the connector-specific documentation? (not
applicable)
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)? (no new
dependencies)
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files? (not applicable: test scope only)
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by Claude Code.
> YARN - Exclude third-party Jetty and servlet API from the catalog-webapp and
> timelineservice-hbase tests
> --------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-20012
> URL: https://issues.apache.org/jira/browse/HADOOP-20012
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test, yarn
> Reporter: Jose Luis López
> Priority: Minor
>
> *Scope*:
> * hadoop-yarn-applications-catalog-webapp/pom.xml: on solr-core and
> solr-test-framework, exclude Solr's own Jetty modules and the servlet API:
> jetty-alpn-server, jetty-alpn-java-server, jetty-continuation, jetty-deploy,
> jetty-jmx, jetty-rewrite, jetty-security, jetty-servlets, http2-server and
> javax.servlet:javax.servlet-api.
> * hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: on hbase-server and
> hbase-server:tests (test scope), exclude javax.servlet:javax.servlet-api
> 3.1.0. HBase's shaded Jetty uses the javax.servlet API, which the module
> still gets through hadoop-common: today javax.servlet-api 3.1.0, and
> jetty-servlet-api 4.0.9 after HADOOP-19970. hbase-server-2 already excludes
> it the same way.
> *Why*: the catalog-webapp tests reach Solr only through EmbeddedSolrServer,
> which runs no servlet container. Solr's Jetty (9.4.44) lags Hadoop's managed
> Jetty, so today the module's test classpath holds two Jetty releases. After
> this change only ${jetty.version} is left. hbase-server 2.6.3 is the only
> third-party dependency outside Solr that brings its own servlet API; without
> the exclusion, timelineservice-hbase-tests would keep a second servlet API
> jar after HADOOP-19970.
> *Impact on Jetty 9*: none. All the changed dependencies are test scope, and
> catalog-webapp's main code uses only solrj. In timelineservice-hbase-tests
> the same javax.servlet-api 3.1.0 jar still arrives through hadoop-common
> until HADOOP-19970.
> *Downstream*: none.
> *CI*: two modules.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
