[
https://issues.apache.org/jira/browse/HADOOP-20012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135121#comment-18135121
]
ASF GitHub Bot commented on HADOOP-20012:
-----------------------------------------
joseluisll commented on PR #8890:
URL: https://github.com/apache/hadoop/pull/8890#issuecomment-6522376374
@pjfanning this is the first piece of the preparation to 19970. Yetus is
green except the test4tests, and build is green. Please review this PR first.
> YARN - Exclude third-party Jetty and servlet API from the catalog-webapp and
> timelineservice-hbase tests
> --------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-20012
> URL: https://issues.apache.org/jira/browse/HADOOP-20012
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test, yarn
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> *Scope*:
> * hadoop-yarn-applications-catalog-webapp/pom.xml: solr-test-framework
> already depends on solr-core (where EmbeddedSolrServer and NodeConfig live),
> so drop the direct solr-core declaration and keep solr-test-framework (test
> scope) as the only Solr test dependency. It carries the single exclusion list
> of Solr's own Jetty modules and servlet API: jetty-io, jetty-xml, jetty-http,
> jetty-client, jetty-alpn-client, jetty-alpn-java-client, jetty-alpn-server,
> jetty-alpn-java-server, jetty-continuation, jetty-deploy, jetty-jmx,
> jetty-rewrite, jetty-security, jetty-servlets, http2-hpack, http2-client,
> http2-common, http2-http-client-transport, http2-server,
> javax.servlet:javax.servlet-api, plus commons-collections and jcl-over-slf4j.
> A Solr upgrade that adds a Jetty artifact needs one entry (review on PR
> #8699).
> * jetty-alpn-java-client: Solr declares 9.4.44, and the managed 9.4.58 copy
> won only through Maven's declaration-order tie-break via
> http2-http-client-transport. Exclude it, as solr-solrj already does.
> * hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: on hbase-server and
> hbase-server:tests (test scope), exclude javax.servlet:javax.servlet-api
> 3.1.0. HBase's shaded Jetty uses the javax.servlet API, which the module
> still gets through hadoop-common: today javax.servlet-api 3.1.0, and
> jetty-servlet-api 4.0.9 after HADOOP-19970. hbase-server-2 already excludes
> it the same way.
> *Why*: the catalog-webapp tests reach Solr only through EmbeddedSolrServer,
> which runs no servlet container. Solr's Jetty (9.4.44) lags Hadoop's managed
> Jetty, so today the module's test classpath holds two Jetty releases. After
> this change only ${jetty.version} is left. hbase-server 2.6.3 is the only
> third-party dependency outside Solr that brings its own servlet API; without
> the exclusion, timelineservice-hbase-tests would keep a second servlet API
> jar after HADOOP-19970.
> *Impact on Jetty 9*: none. All the changed dependencies are test scope, and
> catalog-webapp's main code uses only solrj. solr-core 8.11.2 stays on the
> test classpath through solr-test-framework: dependency:list (test scope) of
> catalog-webapp gives the same 238 artifacts with the single list as with the
> exclusions on both Solr artifacts. In timelineservice-hbase-tests the same
> javax.servlet-api 3.1.0 jar still arrives through hadoop-common until
> HADOOP-19970.
> *Downstream*: none.
> *CI*: two modules.
> *PR*: https://github.com/apache/hadoop/pull/8890
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
