[
https://issues.apache.org/jira/browse/HADOOP-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134771#comment-18134771
]
ASF GitHub Bot commented on HADOOP-20015:
-----------------------------------------
joseluisll opened a new pull request, #8893:
URL: https://github.com/apache/hadoop/pull/8893
### Description of PR
Part of HADOOP-19912 (Jetty 12 on ee8): split out of #8699, where it was
reviewed.
These modules use Jetty web classes directly but only got them transitively
through `hadoop-common`. Declaring them is what lets the Jetty 12 upgrade swap
them for the ee8 artifacts module by module.
- applicationhistoryservice (`WebAppContext`, `FilterHolder`): declare
`jetty-webapp` and `jetty-servlet`, scope `provided`, the scope they already
resolve at through the provided `hadoop-common`.
- router (serves the UI2 war through `WebAppContext`): declare
`jetty-webapp` at compile scope, so it stays on the Router's runtime classpath.
- resourcemanager (hosts UI2 through `WebAppContext`) and yarn-common (its
`WebApps` exposes `WebAppContext`): declare `jetty-webapp`, scope `provided`.
- `TestRollingLevelDBTimelineStore` logged through
`org.eclipse.jetty.util.log.Log`, which Jetty 10 and later no longer have; it
now logs through SLF4J.
No change for Jetty 9: the same artifacts, version and scope as before.
### How was this patch tested?
- The fork's artifact and dependency comparison against trunk (dist,
per-module dependency lists, downstream resolution) shows no difference from
this change.
- In the fork's CI, the one failure was a timeout in
`TestMRIntermediateDataEncryption`. That is the known intermittent HDFS-read
stall over loopback (MAPREDUCE-7099), unrelated to this change.
### For code changes:
- [x] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint declared according to the connector-specific documentation? (not
applicable)
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)? (no new
dependencies; already present transitively)
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files? (not applicable)
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by Claude Code.
> YARN - Declare the Jetty web artifacts that yarn-common, the ResourceManager,
> the ApplicationHistoryServer and the Router use
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-20015
> URL: https://issues.apache.org/jira/browse/HADOOP-20015
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jose Luis López
> Priority: Major
>
> *Scope*:
> * hadoop-yarn-server-applicationhistoryservice/pom.xml:
> ApplicationHistoryServer uses org.eclipse.jetty.webapp.WebAppContext and
> org.eclipse.jetty.servlet.FilterHolder. Declare jetty-webapp and
> jetty-servlet with scope provided, the scope they already resolve at through
> the provided hadoop-common.
> * hadoop-yarn-server-router/pom.xml: Router serves the UI2 war through
> WebAppContext. Declare jetty-webapp at compile scope. A test scope would
> override the inherited compile scope and take it off the Router's runtime
> classpath.
> *Why*: both modules compile against Jetty that they only get transitively.
> Declaring it makes the HADOOP-19972 change a rename of these entries to
> jetty-ee8-*.
> *Impact on Jetty 9*: none. Same artifacts, version and scope as today.
> *Downstream*: none.
> *CI*: two modules.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
