[
https://issues.apache.org/jira/browse/HADOOP-20003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139386#comment-18139386
]
ASF GitHub Bot commented on HADOOP-20003:
-----------------------------------------
hadoop-yetus commented on PR #8945:
URL: https://github.com/apache/hadoop/pull/8945#issuecomment-6677155719
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 3 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 46m 45s | | trunk passed |
| +1 :green_heart: | compile | 17m 27s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 18m 37s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 5m 54s | | trunk passed |
| +1 :green_heart: | mvnsite | 5m 4s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 59s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 3m 59s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 9m 24s | | trunk passed |
| +1 :green_heart: | shadedclient | 34m 33s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 56s | | the patch passed |
| +1 :green_heart: | compile | 16m 38s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 16m 38s | | the patch passed |
| +1 :green_heart: | compile | 17m 47s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 17m 47s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 5m 43s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8945/1/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 1 new + 101 unchanged - 0 fixed = 102 total (was
101) |
| +1 :green_heart: | mvnsite | 5m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 4m 2s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 3m 53s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 9m 45s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 52s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 48s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 24m 17s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 38s | | hadoop-kms in the patch passed.
|
| +1 :green_heart: | unit | 3m 7s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 15s | | The patch does not
generate ASF License warnings. |
| | | 290m 15s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8945/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8945 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 11086929d7c3 5.15.0-198-generic #208-Ubuntu SMP Fri Sep 4
10:22:38 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / bbd35ec261b9dd84f423aa8731468b7b070ae214 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8945/1/testReport/ |
| Max. process+thread count | 3117 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms
hadoop-hdfs-project/hadoop-hdfs-client U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8945/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Clients shall read an HTTP refusal's reason from the response body
> ------------------------------------------------------------------
>
> Key: HADOOP-20003
> URL: https://issues.apache.org/jira/browse/HADOOP-20003
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, hadoop-auth, hdfs-client, kms
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> Several Hadoop clients take the reason a server refused a request from the
> HTTP reason phrase ({{HttpURLConnection#getResponseMessage()}}). The same
> text is also in the response body: {{sendError}} writes it into the error
> page's MESSAGE row, which looks the same on Jetty 9.4 and on Jetty 12. Jetty
> 12 sends no custom reason phrase (HADOOP-19972), so these clients would only
> see the standard text, e.g. "Unauthorized" instead of "Authentication
> required".
> h3. Changes
> * New {{ResponseDetail}} in hadoop-auth ({{@InterfaceAudience.Private}})
> reads a capped amount of the error body. It returns the MESSAGE row of a
> Jetty error page, or the text of any other page with the markup stripped. It
> falls back to the phrase when there is no body. A JSON error envelope is left
> alone, and its phrase is reported, because that envelope is sent with
> {{setStatus}}, not {{sendError}}.
> * {{AuthenticatedURL}} and {{HttpExceptionUtils#validateResponse}} use it to
> report failures.
> * {{WebHdfsFileSystem}} uses it for a 401 and the neighbouring error arms.
> * {{KMSClientProvider}} uses it to decide whether to reset its token and
> re-authenticate. That decision matches on "Invalid signature" and "Anonymous
> requests are disallowed", which would never match the standard phrase.
> h3. Compatibility
> No change against Jetty 9.4 servers: the MESSAGE row holds exactly the text
> the phrase carried.
> h3. Tests
> {{TestHttpExceptionUtils}} and {{TestAuthenticatedURL}} cover the body and
> fallback cases. A new {{TestKMS}} case covers the re-authentication retry.
> h3. Not in scope
> {{NetworkTopologyServlet}} loses its reason on Jetty 9.4 too (a failed dump
> answers 200). That needs its own JIRA.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
