joseluisll commented on code in PR #8891:
URL: https://github.com/apache/hadoop/pull/8891#discussion_r4496805389
##########
LICENSE-binary:
##########
@@ -625,7 +625,6 @@ CDDL 1.1 + GPLv2 with classpath exception
-----------------------------------------
com.sun.xml.bind:jaxb-impl:2.2.3-1
-javax.annotation:javax.annotation-api:1.3.2
Review Comment:
Ran the check, and you were right to ask — `javax.annotation-api-1.3.2.jar`
**does** still end up in the dist:
```
mvn --projects
hadoop-cloud-storage-project/hadoop-gcp,hadoop-cloud-storage-project/hadoop-cloud-storage-dist
\
package -Pdist -Dhadoop-gcp-package -DskipTests
```
`hadoop-cloud-storage-dist-3.6.0-SNAPSHOT/share/hadoop/common/lib/` contains
it (105 jars). It arrives through `google-cloud-storage:2.52.0`'s direct
compile-scope dep, which this PR's exclusion (on `javax-websocket-server-impl`)
doesn't touch — so the entry was load-bearing and stays. Restored it in
c9e39dad18e, in both `LICENSE-binary` (CDDL 1.1 + GPLv2 CE) and `NOTICE-binary`
(Oracle stanza); that part of the diff is now identical to trunk, and the only
license change left is the `jakarta.annotation-api:1.3.5` addition under EPL
2.0.
On (2): the shaded `hadoop-gcp` jar bundles **zero** `javax/annotation`
entries (the `artifactSet` you point at doesn't include it), and scanning every
class in it, all `javax.annotation.*` references are jsr305-style annotations
(`Nullable`, `CheckForNull`, `Nonnull`, `concurrent.*`, `meta.*`) — not one
class from `javax.annotation-api` (`PostConstruct`, `Resource`, `Generated`,
...). The dist's `hadoop-gcp` runtime classpath also gets
`jakarta.annotation-api-1.3.5.jar` through `hadoop-common`, which provides
those classes anyway. So nothing needs the jar; it ships as a redundant extra
either way, same as it does on trunk today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
