pjfanning commented on code in PR #8891: URL: https://github.com/apache/hadoop/pull/8891#discussion_r4496372592
########## NOTICE-binary: ########## @@ -456,6 +456,9 @@ The following artifacts are EPL and ASL2. The following artifacts are EPL and CDDL 1.0. * org.eclipse.jetty.orbit:javax.mail.glassfish +The following artifacts are EPL 2.0 and GPLv2 with classpath exception. Review Comment: This says EPL 2.0 and GPLv2 with classpath exception, but `LICENSE-binary` lists `jakarta.annotation-api` under EPL 2.0 only. Could the two files be made consistent? No other `jakarta.*` artifact has a stanza in `NOTICE-binary`, so dropping this one may be the simplest fix. Otherwise `LICENSE-binary` should mention the GPLv2 CE option too. ########## LICENSE-binary: ########## @@ -625,7 +625,6 @@ CDDL 1.1 + GPLv2 with classpath exception ----------------------------------------- com.sun.xml.bind:jaxb-impl:2.2.3-1 -javax.annotation:javax.annotation-api:1.3.2 Review Comment: Could you check `hadoop-gcp` before this entry goes? `google-cloud-storage:2.52.0` has a compile-scope dependency on `javax.annotation-api:1.3.2`, and the shade `artifactSet` in `hadoop-gcp` does not include `javax.annotation`, so those classes are not bundled in the shaded jar. I have not built this, so can you run a dist with `-Dhadoop-gcp-package` and confirm two things? 1. Whether `javax.annotation-api-1.3.2.jar` still ends up in the dist. If it does, it still needs this licence entry. 2. Whether `hadoop-gcp` still has everything it needs at runtime. If the jar is not shipped, the `javax.annotation` classes have to come from somewhere else on its classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
