[ 
https://issues.apache.org/jira/browse/HADOOP-9155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540117#comment-13540117
 ] 

Colin Patrick McCabe commented on HADOOP-9155:
----------------------------------------------

Looks good to me.  Did you test that FSShell's copyToLocal no longer creates 
local files with 0777? 
                
> FsPermission should have different default value, 777 for directory and 666 
> for file
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9155
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>         Attachments: HADOOP-9155.patch, HADOOP-9155.v2.patch
>
>
> The default permission for {{FileSystem#create}} is the same default as for 
> {{FileSystem#mkdirs}}, namely {{0777}}. It would make more sense for the 
> default to be {{0666}} for files and {{0777}} for directories.  The current 
> default leads to a lot of files being created with the executable bit that 
> really should not be.  One example is anything created with FsShell's 
> copyToLocal.
> For reference, {{fopen}} creates files with a mode of {{0666}} (minus 
> whatever bits are set in the umask; usually {{0022}}.  This seems to be the 
> standard behavior and we should follow it.  This is also a regression since 
> branch-1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to