[ 
https://issues.apache.org/jira/browse/HADOOP-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576180#comment-13576180
 ] 

Alejandro Abdelnur commented on HADOOP-9117:
--------------------------------------------

Chris, thanks for taking the time to give the patch a spin. Answering your 
questions:

On "I see ...", correct, as the Mojo adds it to the source path of the maven 
project no need to do it here. Regarding Eclipse, I'm not sure it will break 
anything. In the case of IntelliJ (what I use), IntelliJ detects 
generated-sources dirs automatically without parsing understanding the 
buildhelper plugin. I'd assume Eclipse does the same.

On 'Is this rename correct?...' Yes, the reason was to make clear this is here 
because of the JSP compilation and not because of protobuf.
                
> replace protoc ant plugin exec with a maven plugin
> --------------------------------------------------
>
>                 Key: HADOOP-9117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9117
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.2-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch, 
> HADOOP-9117.patch
>
>
> The protoc compiler is currently invoked using ant plugin exec. There is a 
> bug in the ant plugin exec task which does not consume the STDOUT or STDERR 
> appropriately making the build to stop sometimes (you need to press enter to 
> continue).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to