[ https://issues.apache.org/jira/browse/HADOOP-9485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646127#comment-13646127 ]
Hadoop QA commented on HADOOP-9485: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12581232/HADOOP-9485.004.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDistributedFileSystem {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2498//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2498//console This message is automatically generated. > inconsistent defaults for hadoop.rpc.socket.factory.class.default > ----------------------------------------------------------------- > > Key: HADOOP-9485 > URL: https://issues.apache.org/jira/browse/HADOOP-9485 > Project: Hadoop Common > Issue Type: Bug > Components: net > Affects Versions: 2.0.5-beta > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-9485.001.patch, HADOOP-9485.002.patch, > HADOOP-9485.003.patch, HADOOP-9485.004.patch > > > In {{core-default.xml}}, {{hadoop.rpc.socket.factory.class.default}} defaults > to {{org.apache.hadoop.net.StandardSocketFactory}}. However, in > {{CommonConfigurationKeysPublic.java}}, there is no default for this key. > This is inconsistent (defaults in the code versus defaults in the XML files > should match.) It also leads to problems with {{RemoteBlockReader2}}, since > the default {{SocketFactory}} creates a {{Socket}} without an associated > channel. {{RemoteBlockReader2}} cannot use such a {{Socket}}. > This bug only really becomes apparent when you create a {{Configuration}} > using the {{Configuration(loadDefaults=true)}} constructor. Thanks to AB > Srinivasan for his help in discovering this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira