[ https://issues.apache.org/jira/browse/HADOOP-9485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647333#comment-13647333 ]
Todd Lipcon commented on HADOOP-9485: ------------------------------------- I disagree with the approach of having differing defaults between the code and the hdfs-default.xml. Why is it risky to change the default in the code to match the default from the XML file? 99.9% of non-buggy users should be using hdfs-default.xml (which is shipped in our jars) or manually overriding. If someone is relying on the behavior with the XML file not present, I don't think we need to maintain that case. > inconsistent defaults for hadoop.rpc.socket.factory.class.default > ----------------------------------------------------------------- > > Key: HADOOP-9485 > URL: https://issues.apache.org/jira/browse/HADOOP-9485 > Project: Hadoop Common > Issue Type: Bug > Components: net > Affects Versions: 2.0.5-beta > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-9485.001.patch, HADOOP-9485.002.patch, > HADOOP-9485.003.patch, HADOOP-9485.004.patch, HADOOP-9485.005.patch > > > In {{core-default.xml}}, {{hadoop.rpc.socket.factory.class.default}} defaults > to {{org.apache.hadoop.net.StandardSocketFactory}}. However, in > {{CommonConfigurationKeysPublic.java}}, there is no default for this key. > This is inconsistent (defaults in the code versus defaults in the XML files > should match.) It also leads to problems with {{RemoteBlockReader2}}, since > the default {{SocketFactory}} creates a {{Socket}} without an associated > channel. {{RemoteBlockReader2}} cannot use such a {{Socket}}. > This bug only really becomes apparent when you create a {{Configuration}} > using the {{Configuration(loadDefaults=true)}} constructor. Thanks to AB > Srinivasan for his help in discovering this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira