[
https://issues.apache.org/jira/browse/HADOOP-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708233#comment-13708233
]
Tsz Wo (Nicholas), SZE commented on HADOOP-9716:
------------------------------------------------
> ... Currently in Rpc response I did not add the client Id. ...
Yes, we do not have client id but we already have callId in
RpcResponseHeaderProto. Client id is not needed since the client receiving the
response knows its own id.
> Do you mean add it to the response? ...
I suggest also adding retry number to both RpcRequestHeaderProto and
RpcResponseHeaderProto since, currently, call id uniquely identifies calls
including retires. If we use the same call id for retries, then we need call
id + retry number to uniquely identifies them. Otherwise, there will be more
change as you suggested earlier.
> Move the Rpc request call ID generation to client side InvocationHandler
> ------------------------------------------------------------------------
>
> Key: HADOOP-9716
> URL: https://issues.apache.org/jira/browse/HADOOP-9716
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Suresh Srinivas
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: c9716_20130712b.patch, c9716_20130712.patch,
> c9716_20130713b.patch, c9716_20130713c.patch, c9716_20130713.patch
>
>
> Currently when RetryInvocationHandler is used to retry an RPC request, a new
> RPC request call ID is generated. This jira proposes moving call ID
> generation to InvocationHandler so that retried RPC requests retain the same
> call ID. This is needed for RetryCache functionality proposed in HDFS-4942.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
