[ https://issues.apache.org/jira/browse/HADOOP-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710700#comment-13710700 ]
Suresh Srinivas commented on HADOOP-9716: ----------------------------------------- Still reviewing the change. One comment, for call ID generation the existing code that does in Client to me seems better than moving to a separate CallIdGenerator class. > Move the Rpc request call ID generation to client side InvocationHandler > ------------------------------------------------------------------------ > > Key: HADOOP-9716 > URL: https://issues.apache.org/jira/browse/HADOOP-9716 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Reporter: Suresh Srinivas > Assignee: Tsz Wo (Nicholas), SZE > Attachments: c9716_20130712b.patch, c9716_20130712.patch, > c9716_20130713b.patch, c9716_20130713c.patch, c9716_20130713.patch, > c9716_20130715.patch, c9716_20130716b.patch, c9716_20130716c.patch, > c9716_20130716.patch > > > Currently when RetryInvocationHandler is used to retry an RPC request, a new > RPC request call ID is generated. This jira proposes moving call ID > generation to InvocationHandler so that retried RPC requests retain the same > call ID. This is needed for RetryCache functionality proposed in HDFS-4942. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira