[
https://issues.apache.org/jira/browse/HADOOP-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740106#comment-13740106
]
Hadoop QA commented on HADOOP-9872:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12597997/HADOOP-9872.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2980//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2980//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2980//console
This message is automatically generated.
> Improve protoc version handling and detection
> ---------------------------------------------
>
> Key: HADOOP-9872
> URL: https://issues.apache.org/jira/browse/HADOOP-9872
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.1.0-beta
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 2.1.0-beta
>
> Attachments: HADOOP-9872.patch
>
>
> HADOOP-9845 bumped up protoc from 2.4.1 to 2.5.0, but we run into a few
> quirks:
> * 'protoc --version' in 2.4.1 exits with 1
> * 'protoc --version' in 2.5.0 exits with 0
> * if you have multiple protoc in your environment, you have to the the one
> you want to use in the PATH before building hadoop
> * build documentation and requirements of protoc are outdated
> This patch does:
> * handles protoc version correctly independently of the exit code
> * if HADOOP_PROTOC_PATH env var is defined, it uses it as the protoc
> executable * if HADOOP_PROTOC_PATH is not defined, it picks protoc from the
> PATH
> * documentation updated to reflect 2.5.0 is required
> * enforces the version of protoc and protobuf JAR are the same
> * Added to VersionInfo the protoc version used (sooner or later this will be
> useful for in a troubleshooting situation).
> [~vicaya] suggested to make the version check for protoc lax (i.e. 2.5.*).
> While working on the patch I've thought about that. But that would introduce
> a potential mismatch between protoc and protobuff JAR.
> Still If you want to use different version of protoc/protobuff from the one
> defined in the POM, you can use the -Dprotobuf.version=#### to specify your
> alternate version. But I would recommend not to do this, because if you
> publish the artifacts to a Maven repo, the fact you used
> -Dprotobuf.version=#### will be lost and the version defined in the POM
> properties will be used (IMO Maven should use the effective POM on deploy,
> but they don't).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
