[ https://issues.apache.org/jira/browse/HADOOP-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740300#comment-13740300 ]
Hudson commented on HADOOP-9872: -------------------------------- SUCCESS: Integrated in Hadoop-trunk-Commit #4259 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4259/]) HADOOP-9872. Improve protoc version handling and detection. (tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1514068) * /hadoop/common/trunk/BUILDING.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CLIMiniCluster.apt.vm * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/SingleCluster.apt.vm * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/pom.xml * /hadoop/common/trunk/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocMojo.java * /hadoop/common/trunk/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/README * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml > Improve protoc version handling and detection > --------------------------------------------- > > Key: HADOOP-9872 > URL: https://issues.apache.org/jira/browse/HADOOP-9872 > Project: Hadoop Common > Issue Type: Bug > Components: build > Affects Versions: 2.1.0-beta > Reporter: Alejandro Abdelnur > Assignee: Alejandro Abdelnur > Priority: Blocker > Fix For: 2.1.0-beta > > Attachments: HADOOP-9872.patch > > > HADOOP-9845 bumped up protoc from 2.4.1 to 2.5.0, but we run into a few > quirks: > * 'protoc --version' in 2.4.1 exits with 1 > * 'protoc --version' in 2.5.0 exits with 0 > * if you have multiple protoc in your environment, you have to the the one > you want to use in the PATH before building hadoop > * build documentation and requirements of protoc are outdated > This patch does: > * handles protoc version correctly independently of the exit code > * if HADOOP_PROTOC_PATH env var is defined, it uses it as the protoc > executable * if HADOOP_PROTOC_PATH is not defined, it picks protoc from the > PATH > * documentation updated to reflect 2.5.0 is required > * enforces the version of protoc and protobuf JAR are the same > * Added to VersionInfo the protoc version used (sooner or later this will be > useful for in a troubleshooting situation). > [~vicaya] suggested to make the version check for protoc lax (i.e. 2.5.*). > While working on the patch I've thought about that. But that would introduce > a potential mismatch between protoc and protobuff JAR. > Still If you want to use different version of protoc/protobuff from the one > defined in the POM, you can use the -Dprotobuf.version=#### to specify your > alternate version. But I would recommend not to do this, because if you > publish the artifacts to a Maven repo, the fact you used > -Dprotobuf.version=#### will be lost and the version defined in the POM > properties will be used (IMO Maven should use the effective POM on deploy, > but they don't). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira