[
https://issues.apache.org/jira/browse/HADOOP-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974612#comment-13974612
]
Hadoop QA commented on HADOOP-10522:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640897/hadoop-10522.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3817//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3817//console
This message is automatically generated.
> JniBasedUnixGroupMapping mishandles errors
> ------------------------------------------
>
> Key: HADOOP-10522
> URL: https://issues.apache.org/jira/browse/HADOOP-10522
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Critical
> Attachments: hadoop-10522.patch
>
>
> The mishandling of errors in the jni user-to-groups mapping modules can cause
> segmentation faults in subsequent calls. Here are the bugs:
> 1) If {{hadoop_user_info_fetch()}} returns an error code that is not ENOENT,
> the error may not be handled at all. This bug was found by [~cnauroth].
> 2) In {{hadoop_user_info_fetch()}} and {{hadoop_group_info_fetch()}}, the
> global {{errno}} is directly used. This is not thread-safe and could be the
> cause of some failures that disappeared after enabling the big lookup lock.
> 3) In the above methods, there is no limit on retries.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
