[
https://issues.apache.org/jira/browse/HADOOP-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975857#comment-13975857
]
Colin Patrick McCabe commented on HADOOP-10522:
-----------------------------------------------
[~kihwal], it seems like you missed my review. You probably didn't hit refresh
soon enough. Do you mind if I back this out so we can fix some of the issues
with this patch?
> JniBasedUnixGroupMapping mishandles errors
> ------------------------------------------
>
> Key: HADOOP-10522
> URL: https://issues.apache.org/jira/browse/HADOOP-10522
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Critical
> Fix For: 3.0.0, 2.4.1
>
> Attachments: hadoop-10522.patch
>
>
> The mishandling of errors in the jni user-to-groups mapping modules can cause
> segmentation faults in subsequent calls. Here are the bugs:
> 1) If {{hadoop_user_info_fetch()}} returns an error code that is not ENOENT,
> the error may not be handled at all. This bug was found by [~cnauroth].
> 2) In {{hadoop_user_info_fetch()}} and {{hadoop_group_info_fetch()}}, the
> global {{errno}} is directly used. This is not thread-safe and could be the
> cause of some failures that disappeared after enabling the big lookup lock.
> 3) In the above methods, there is no limit on retries.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
