[ 
https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149615#comment-14149615
 ] 

Jason Lowe commented on HADOOP-11049:
-------------------------------------

Thanks for the patch, Sangjin!

I think "application-classloader.properties" might be too generic.  Maybe we 
should add the org.apache.hadoop. prefix or otherwise make it more unique?

Having one giant property line is not great for maintenance, as every patch 
against it will be a big blob of text changing to another big blob of text.  We 
should split the value on multiple lines so it's easier to read and easier to 
maintain.



> javax package system class default is too broad
> -----------------------------------------------
>
>                 Key: HADOOP-11049
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11049
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.6.0
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Minor
>         Attachments: HADOOP-11049.patch, HADOOP-11049.patch
>
>
> The system class default defined in ApplicationClassLoader has "javax.". This 
> is too broad. The intent of the system classes is to exempt classes that are 
> provided by the JDK along with hadoop and minimally necessary dependencies 
> that are guaranteed to be on the system classpath. "javax." is too broad for 
> that.
> For example, JSR-330 which is part of JavaEE (not JavaSE) has "javax.inject". 
> Packages like them should not be declared as system classes, as they will 
> result in ClassNotFoundException if they are needed and present on the user 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to