[ 
https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150038#comment-14150038
 ] 

Hadoop QA commented on HADOOP-11049:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12671514/HADOOP-11049.patch
  against trunk revision 3a1f981.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.ha.TestZKFailoverControllerStress
                  org.apache.hadoop.mapreduce.lib.input.TestMRCJCFileInputFormat

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4813//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4813//console

This message is automatically generated.

> javax package system class default is too broad
> -----------------------------------------------
>
>                 Key: HADOOP-11049
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11049
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.6.0
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Minor
>         Attachments: HADOOP-11049.patch, HADOOP-11049.patch, 
> HADOOP-11049.patch
>
>
> The system class default defined in ApplicationClassLoader has "javax.". This 
> is too broad. The intent of the system classes is to exempt classes that are 
> provided by the JDK along with hadoop and minimally necessary dependencies 
> that are guaranteed to be on the system classpath. "javax." is too broad for 
> that.
> For example, JSR-330 which is part of JavaEE (not JavaSE) has "javax.inject". 
> Packages like them should not be declared as system classes, as they will 
> result in ClassNotFoundException if they are needed and present on the user 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to